Important fixes for VAT-included stores [2-3-stable]#139
Open
alepore wants to merge 13 commits intospree-contrib:2-3-stablefrom
Open
Important fixes for VAT-included stores [2-3-stable]#139alepore wants to merge 13 commits intospree-contrib:2-3-stablefrom
alepore wants to merge 13 commits intospree-contrib:2-3-stablefrom
Conversation
Conflicts: spec/features/paypal_spec.rb
gives some matching problems, and i don't think it's very useful
as in other similar specs
phantomjs 1.9.8 👍 This reverts commit 01c30c8.
…through PaypalExpress checkout
Member
Author
|
@peterfealey @paulgroves @ouechtasvu @hates @IrvinFan please take a look |
alepore
changed the title
alepore
force-pushed
the
included-vat-fix
branch
from
ba5b802 to
7123063
Compare
alepore
force-pushed
the
included-vat-fix
branch
from
7123063 to
f559cfc
Compare
Contributor
Contributor
|
This should also be merged into master |
Member
Author
|
in the end i didn't use this code but i think it's still relevant. |
Member
|
I don't use or care about paypal at all. The specs fail terribly on this extension for me as well so I'm not going to be touching anything here until someone fixes them. The changes in the works over at spree/spree#6227 may be relevant to fixing this issue though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enable paypal payments for stores with VAT-included prices (very common in the EU) and should finally solve #129 and #17.
The first fix was already included in
2-2-stable, this just adds a regression spec.The second one it's a kind of workaround because paypal does not accept negative taxes amounts.
But this is very important because on Spree we have negative taxes when a country without VAT buys from a VAT-included store, like in this example:
This is also including all the commits from #138 to get green specs.